Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkboxes in Manage Websites form #8255

Merged
merged 1 commit into from Jul 1, 2015
Merged

Fix checkboxes in Manage Websites form #8255

merged 1 commit into from Jul 1, 2015

Conversation

barbushin
Copy link
Contributor

There is a popular conflict between Angular and iCheck. I tried different solutions, like using custom derective for iCheck drgullin/icheck#62, but it does not helps.

I think for now we can just disable iCheck for that Angular form.

Closes #8247

@barbushin barbushin added the Needs Review PRs that need a code review label Jun 30, 2015
@tsteur tsteur added this to the 2.14.0 milestone Jul 1, 2015
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 1, 2015
tsteur added a commit that referenced this pull request Jul 1, 2015
@tsteur
Merge pull request #8255 from barbushin/8247_icheck_angular_conflict
15d6b07 
Fix checkboxes in Manage Websites form
@tsteur tsteur merged commit 15d6b07 into matomo-org:master Jul 1, 2015
@tsteur
Copy link
Member

tsteur commented Jul 1, 2015

Nice! Hopefully we can get rid of iCheck at some point. It always causes problems...

@tsteur
Copy link
Member

tsteur commented Jul 6, 2015

Just FYI: Google released a lite version of material design which could be used as an alternative for iCheck see eg http://www.getmdl.io/components/index.html#toggles-section . It also provides nice switches etc

@mattab
Copy link
Member

mattab commented Jul 8, 2015

Nice! Hopefully we can get rid of iCheck at some point. It always causes problems...

definitely, we had so many bugs because of iCheck!

Just FYI: Google released a lite version of material design which could be used as an alternative for iCheck

This looks great, shall we migrate to it?

@barbushin
Copy link
Contributor Author

I'm a big fan of Material Design, and https://github.com/google/material-design-lite is really great. But there is a huge work to migrate, I think. May be we should ask some professional front end developer to estimate this kind of migration?

Regarding building complex interactive Web applications, I think that there should be professional front-end programmer with relative experience.

@tsteur
Copy link
Member

tsteur commented Jul 9, 2015

This would be only about checkboxes, radio, and switches. Not a whole redesign. We're doing the whole redesign more or less step by step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barbushin @tsteur @mattab