Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/Editing a new goal doesn't update its "state" and some UI issues #8244

Closed
tsteur opened this issue Jun 29, 2015 · 4 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Jun 29, 2015

While testing #8242 I noticed some issues with "Adding new goals" and probably as well with "Editing goals". I'm using Chrome 43 on MacOS. To reproduce go to "Your Username in top right menu => Goals => Create new goal"

  • When selecting another value in the select field "Goal is triggered" the form is not immediately updated. I have to click on the select box again to see the UI change. This results in very weird states eg it says "manually" but it still shows all the radio boxes on the other side. Or it says "when visitors" but I'm not able to select any of the radio boxes.
  • Missing space below "Goal is triggered" and checkbox "Case sensitive match" is positioned on the right instead of left. The labels also seem to look different etc but this should not be part of this issue as it might be quite a bit of work.

See screenshot:

goals_management

  • Wording is incorrect in "Manage Goals" overview. It says "Create a new goal" but then the opened form says "Add a new goal". In Websites Management / User Management we use the term "Add" and it should be used there as well
  • When creating a goal triggered "Manually" and then editing a goal the radio boxes look disabled but still can be selected when choosing "Goal is triggered when visitors". They should not look disabled

goals_radio

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Jun 29, 2015
@barbushin barbushin assigned barbushin and unassigned barbushin Jun 30, 2015
@mattab
Copy link
Member

mattab commented Jul 1, 2015

@barbushin could you maybe take a look at this issue?

@mattab mattab added this to the 2.14.0 milestone Jul 1, 2015
@barbushin barbushin self-assigned this Jul 2, 2015
@barbushin barbushin added the Needs Review PRs that need a code review label Jul 2, 2015
@mattab mattab reopened this Jul 6, 2015
@mattab
Copy link
Member

mattab commented Jul 6, 2015

Not fixed:

  • Wording is incorrect in "Manage Goals" overview. It says "Create a new goal" but then the opened form says "Add a new goal". In Websites Management / User Management we use the term "Add" and it should be used there as well
  • When creating a goal triggered "Manually" and then editing a goal the radio boxes look disabled but still can be selected when choosing "Goal is triggered when visitors". They should not look disabled

@barbushin
Copy link
Contributor

There is a new PR with fixes #8279 Sorry, I forgot to pay attention to that bugs.

@mattab
Copy link
Member

mattab commented Jul 12, 2015

No worries @barbushin and cheers for issuing the new PR

@mattab mattab reopened this Jul 12, 2015
@mattab mattab closed this as completed Jul 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review
Projects
None yet
Development

No branches or pull requests

3 participants