Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor map NaN error in browser console #8243

Closed
andrzejewsky opened this issue Jun 29, 2015 · 7 comments
Closed

Visitor map NaN error in browser console #8243

andrzejewsky opened this issue Jun 29, 2015 · 7 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@andrzejewsky
Copy link

Hi, I found problem with visitor map, take a look on the screenshot:

zrzut ekranu 2015-06-29 o 17 10 00

Look at the console, we can see a lot of "NaN" errors. I think, this problem occur only if we will select Canada

@andrzejewsky andrzejewsky added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 29, 2015
@tsteur
Copy link
Member

tsteur commented Jun 29, 2015

Can you let us know what your browser + operating system is and steps to reproduce? Also what's your Piwik version?

@quba
Copy link
Contributor

quba commented Jun 29, 2015

demo.piwik.org on Mac OS X using latest Chrome.

@mattab
Copy link
Member

mattab commented Jul 1, 2015

Since we recently fixed some problems with the map, i'm wondering that maybe it will be fixed in RC2 (coming soon). Let's check bug is still here in RC2 once it will be on the demo.

@mattab mattab added this to the 2.14.0 milestone Jul 1, 2015
@quba
Copy link
Contributor

quba commented Jul 6, 2015

I can still reproduce it using demo.piwik.org (after update)

@barbushin
Copy link
Contributor

Problem was in Kartograph centroid calculation function, it was a popular bug fixed in Kartograph v 0.8.2 (see https://github.com/kartograph/kartograph.js/blob/master/CHANGELOG.md#082).

There was some backward compatibility problem with Kartograph 0.8.6 and 0.8.7, so I just used 0.8.2 release with trivial migration refactoring. Now it works.

@barbushin barbushin added the Needs Review PRs that need a code review label Jul 6, 2015
@mattab
Copy link
Member

mattab commented Jul 7, 2015

Assigning to 2.14.1 to have bit more time to test it

@mattab mattab modified the milestones: 2.14.1, 2.14.0 Jul 7, 2015
@mattab mattab changed the title Visotor map NaN error Visitor map NaN error Jul 12, 2015
@mattab mattab changed the title Visitor map NaN error Visitor map NaN error in browser console Jul 12, 2015
@mattab mattab removed the Needs Review PRs that need a code review label Jul 12, 2015
@mattab
Copy link
Member

mattab commented Jul 12, 2015

PR was reverted in #8335

@mattab mattab reopened this Jul 12, 2015
@mattab mattab modified the milestones: 2.15.0, 2.14.1 Jul 12, 2015
@mattab mattab modified the milestones: 2.14.1, 2.15.0 Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

5 participants