Fixes #7969 escape goal names and patterns on output in goals controller #8231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2015 09:21
…ead of in the Controller class.
…layed in evolution graph tooltips.
diosmosis
added
Bug
|
Awesome 👍 An update script might be needed to unsanitize existing values in database? |
|
Goal names are stored unsanitized. And they were sanitized in PHP, and outputted w/o escaping in twig. Different from every other part of Piwik, and yet, still wrong. Hooray for inconsistency :) |
|
Haha ok I wasn't expecting that :) |
|
This is how to kill some technical debt, nice one @diosmosis |
mattab
pushed a commit
that referenced
this pull request
Jul 12, 2015
Fixes #7969 escape goal names and patterns on output in goals controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Previously, goal names and patterns were escaped in the Goals controller by calling the
Common::sanitizeInputValue()method, and then outputted w/|rawin twig. This PR removes the manual escaping in the Goals controller and removes the|rawfilters in related twig files. It also makes sure jqplot evolution graphs escape series and metric names before displaying tooltips.This fixes #7969, because goal data is used in the JSON jqplot graph data, and since it was escaped in the PHP, it ended up escaped in the JSON. Then jqplot escaped it again.
Fixes #7969