Fixes #8217 regression, make sure temporary metrics are available to UserCountryMap for cities layer #8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 26, 2015 03:05
…ary metrics in this case.
…ed manually in JS.
… IPs + PHP geoip provider.
diosmosis
added
the
not-in-changelog
diosmosis
force-pushed
the
8217_city_regression
branch
from
60335ae
to
a6bc74c
Compare
| // for proper geolocation | ||
| LocationProvider::setCurrentProvider(LocationProvider\GeoIp\Php::ID); | ||
| IPAnonymizer::deactivate(); | ||
|
|
There was a problem hiding this comment.
Would it make sense to make a more specific fixture? This change + adding self::downloadGeoIpDbs() makes the base fixture more complex (and maybe slower, not sure about that), that's why I'm asking.
There was a problem hiding this comment.
default fixture? Isn't that the default fixture used for ui tests?
There was a problem hiding this comment.
Yeah, I don't see how it will slow the tests down, the GeoIP database will only be downloaded if it doesn't exist already. So it will happen once per test run (on travis). Is that what you're worried about?
added 2 commits
June 26, 2015 04:51
diosmosis
pushed a commit
that referenced
this pull request
Jun 26, 2015
diosmosis
added a commit
that referenced
this pull request
Jun 26, 2015
Fixes #8217 regression, make sure temporary metrics are available to UserCountryMap for cities layer + add regions/cities UI tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, also includes UI tests for cities/regions layer, plus change that allows UI tests to send mouse events to specific coordinates.
In order to get some visits to show up on the city map, I had to set the IPs in UITestFixture visits to IPs that have locations. And force the use of GeoIP there.