add constant PIWIK_VENDOR_PATH #8227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craue
force-pushed
the
vendor-path-constant
branch
from
7a4aca1
to
75469d1
Compare
|
Thanks @craue, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
PIWIK_INCLUDE_PATH . '/vendor/...', nowPIWIK_VENDOR_PATH . '/...'should be used. The new constantPIWIK_VENDOR_PATHpoints directly to thevendordir.This is an approach to avoid (future) issues with files not being found when Piwik is installed as a Composer dependency. See #173 and #8226.
I just searched the repo for
vendorand tried to replace it when possible, although there's some code I decided to leave untouched for now to avoid accidentally breaking it. E.g. incore/Profiler.phpthere's one line which could be changed easily but also one line creating a URL based on the path. So please review the changes carefully and let me know if there's something wrong or missing.