You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BugFor errors / faults / flaws / inconsistencies etc.duplicateFor issues that already existed in our issue tracker and were reported previously.MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.
the $urlQuery is: ariba_campaign=Adwords-CPC&ariba_kwd=My killer keyword
and the $parameter is ariba_kwd
Note that the & was inserted when calling parse_url
The comment of the function Piwik_Common::getParameterFromQueryString:
* @param string $urlQuery result of parse_url()['query'] and htmlentitied (& is &) eg. module=test&action=toto or ?page=test
and it does appear that since the "&" is now & it has been htmlspecialchar'ed.
However since the split happens on &, we get &ariba_kwd=My killer keyword and do not match ariba_kwd
Note that this comment indicates that this data is expected in this format:
/**
* Returns the value of a GET parameter $parameter in an URL query $urlQuery
*
* @param string $urlQuery result of parse_url()['query'] and htmlentitied (& is &) eg. module=test&action=toto or ?page=test
* @param string $param
*
* @return string|bool Parameter value if found (can be the empty string!), false if not found
*/
static public function getParameterFromQueryString( $urlQuery, $parameter)
I might try to fix this in my local copy, but I'm new enough to Piwik to be leery of anything more at the moment.
The text was updated successfully, but these errors were encountered:
BugFor errors / faults / flaws / inconsistencies etc.duplicateFor issues that already existed in our issue tracker and were reported previously.MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.
When trying to detect if we have a campaign keyword, the code calls
Piwik_Common::getParameterFromQueryString($this->currentUrlParse['query'], $campaignKeywordVariableName);
the $urlQuery is: ariba_campaign=Adwords-CPC&ariba_kwd=My killer keyword
and the $parameter is ariba_kwd
Note that the & was inserted when calling parse_url
The comment of the function Piwik_Common::getParameterFromQueryString:
and it does appear that since the "&" is now & it has been htmlspecialchar'ed.
However since the split happens on &, we get &ariba_kwd=My killer keyword and do not match ariba_kwd
Note that this comment indicates that this data is expected in this format:
I might try to fix this in my local copy, but I'm new enough to Piwik to be leery of anything more at the moment.
The text was updated successfully, but these errors were encountered: