Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cities are not being shown on the visitors map #8217

Closed
quba opened this issue Jun 25, 2015 · 5 comments
Closed

Cities are not being shown on the visitors map #8217

quba opened this issue Jun 25, 2015 · 5 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
2.14.0

Comments

@quba
Copy link
Contributor

quba commented Jun 25, 2015

When I switch to cities view, I can see the following error in the console:

Uncaught TypeError: Cannot read property 'toFixed' of undefined

I can reproduce it using demo: http://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=day&date=yesterday#/module=UserCountry&action=index&idSite=7&period=day&date=yesterday
@igorkba
Copy link

igorkba commented Jun 25, 2015

browser type and version, name of javascript which throws this exception? I some time see on my console type error from my chrome plugin. :) I don't have permission on the ID site, but when I change ID site to public, it works fine(google chrome 43.0.2357.130):
http://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=day&date=yesterday#/module=UserCountry&action=index&idSite=7&period=day&date=yesterday

@quba
Copy link
Contributor Author

quba commented Jun 25, 2015

Have you changed from Regions to Cities? I was able to reproduce using latest Chrome and Firefox on Mac OSX.

@igorkba
Copy link

igorkba commented Jun 25, 2015

In private mode:
see attachment
regionstocity

@igorkba
Copy link

igorkba commented Jun 25, 2015

I see already, you're right.

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 25, 2015
@mattab mattab added this to the 2.14.0 milestone Jun 25, 2015
@mattab
Copy link
Member

mattab commented Jun 25, 2015

Thanks for the report. Adding to 2.14.0 as this is a regression.

Suggestions:

  • let's add a UI test for the Cities map (eg. Germany)
  • let's add a UI test for the Region map (eg. USA)
  • then we fix the issue and we know it will never break again 👍

@diosmosis diosmosis self-assigned this Jun 26, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
4 participants
@diosmosis @mattab @quba @igorkba