Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlHelper: QueryParameters parser return wrong result. #8215

Closed
Preclowski opened this issue Jun 25, 2015 · 1 comment
Closed

UrlHelper: QueryParameters parser return wrong result. #8215

Preclowski opened this issue Jun 25, 2015 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@Preclowski
Copy link

For example, calling

UrlHelper::getArrayFromQueryString($action->getActionUrl())

For action url

http://piwik.net/index.php?PaywallPlan=40&ArticleId=1

The response looks like

'array(2) {
  \'http://piwik.net/index.php?PaywallPlan\' =>
  string(2) "40"
  \'ArticleId\' =>
  string(1) "1"
}

First parameter is parsed wrong, it should contain only query param name.

@sgiehl
Copy link
Member

sgiehl commented Jun 25, 2015

As defined in the method description getArrayFromQueryString has the query-string as paramater. Your example uses the full url. I don't think this method should try to handle incorrect parameter values

@sgiehl sgiehl closed this as completed Jun 25, 2015
@sgiehl sgiehl added the answered For when a question was asked and we referred to forum or answered it. label Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

2 participants