Make Access::loadSitesIfNeeded() method protected so UserGroups can override it #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to override access loading behavior. Needed by UserGroups plugin.
diosmosis
added
the
c: Platform
diosmosis
added a commit
that referenced
this pull request
Jun 24, 2015
Make Access::loadSitesIfNeeded() method protected so derived classes can override it
diosmosis
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7641 site access loading was changed to use lazy loading. This causes the UserGroups plugin to break, since it adds/changes access levels in
reloadAccess(). To properly change access levels, we have to make theloadSitesIfNeeded()protected.It's possible to modify access levels w/o this, but that requires calling the getSitesIdWith... methods before changing access, then calling the method again. This is, however, not as performant, since the
array_unique/array_mergemethods will be called twice.CC @tsteur Will merge it now, but feel free to let me know if there's an issue.