@diosmosis opened this Pull Request on June 24th 2015 Member

In https://github.com/piwik/piwik/pull/7641 site access loading was changed to use lazy loading. This causes the UserGroups plugin to break, since it adds/changes access levels in reloadAccess(). To properly change access levels, we have to make the loadSitesIfNeeded() protected.

It's possible to modify access levels w/o this, but that requires calling the getSitesIdWith... methods before changing access, then calling the method again. This is, however, not as performant, since the array_unique/array_merge methods will be called twice.

CC @tsteur Will merge it now, but feel free to let me know if there's an issue.

This Pull Request was closed on June 24th 2015
Powered by GitHub Issue Mirror