Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display permanent notification in admin screen for PHP 5.4 warning about EOL #8193

Closed
mattab opened this issue Jun 23, 2015 · 2 comments
Closed

Display permanent notification in admin screen for PHP 5.4 warning about EOL #8193

mattab opened this issue Jun 23, 2015 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Jun 23, 2015

At some point Piwik will require PHP 5.5. #8156

We need to warn users about this at least 6 months before. Since PHP 5.4 is EOL we can start warning users already. Piwik displays such warning for PHP 5.3 so let's display it for PHP 5.4 as well.

Follows up #3877 #6056 #6275
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Jun 23, 2015
@mattab mattab mentioned this issue Jun 23, 2015
Closed
@mattab mattab added this to the 3.0.0 milestone Jul 15, 2015
@tsteur
Copy link
Member

tsteur commented Jul 29, 2015

FYI: In #8452 I changed the notification about EOL to PHP 5.4 see eg http://builds-artifacts.piwik.org/ui-tests.3.0/14501.7/UIIntegrationTest_admin_user_settings . I removed the message that we will drop support for PHP 5.4. Maybe this issue is already closed.

@mattab
Copy link
Member Author

mattab commented Aug 12, 2015

looks good 👍

@mattab mattab closed this as completed Aug 12, 2015
@mattab mattab modified the milestones: 2.15.0, 3.0.0 Aug 12, 2015
mattab added a commit that referenced this issue Nov 2, 2015
@mattab
when PHP is 5.4, display a warning message in a notification, and ask…
a6392f3 
… users to upgrade to PHP 5.5

  #8156
  #8193
@mattab mattab mentioned this issue Nov 2, 2015
Merged
mattab added a commit that referenced this issue Nov 3, 2015
@mattab
Refactor following code review #8156 #8193
45e7d1e
@mattab mattab mentioned this issue Mar 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
2 participants
@tsteur @mattab