New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to test all API endpoints using SystemTestCase::runApiTests #8188
Comments
Would be also useful to:
|
Thanks @kaz231 for the report! We can definitely improve things, in particular:
regarding removing the hacks: sure it would be nice to remove such technical debt, but if it's not an issue then we don't need to do it yet. Similarly we don't need to change the logic to not load all available API methods, since that's not a performance issue. |
@mattab thanks for answer ! Re usage of IntegrationTestCase instead of SystemTestCase won't solve the problem, because IntegrationTestCase extends over SystemTestCase. Re hacks: I totally agree, that's a minor. But it will be great to progressively eliminate them. |
What I meant is that to test an API method, we should not use |
Definitely agree :-) feel free to submit pull requests when you stumble upon and want / can easily fix one tech debt. Reporting them is not directly helpful as it's never ending story :-) |
Steps to reproduce:
Result:
I found that problem is in class https://github.com/piwik/piwik/blob/master/tests/PHPUnit/Framework/TestRequest/Collection.php#L305. There's is condition, that checks if API method starts with "get" and if not, then skips it.
The text was updated successfully, but these errors were encountered: