Better design for errors in popovers #8184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
added
Pull Request WIP
mnapoli
added
Needs Review
| </div>', | ||
| Piwik::translate('General_Error'), | ||
| $errorMessage, | ||
| 'index.php?module=Login&idSite=7&period=day&date=yesterday', |
There was a problem hiding this comment.
idSite is hardcoded to 7
In general Login URL needs to be only index.php?module=Login (other params not needed)
mattab
pushed a commit
that referenced
this pull request
Jun 24, 2015
Better design for errors in popovers
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8087
The popup now shows this error:
instead of this: