Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow api content to be loaded within Piwik #8182

Merged
merged 2 commits into from Jun 23, 2015
Merged

Disallow api content to be loaded within Piwik #8182

merged 2 commits into from Jun 23, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Jun 23, 2015

Can be merged if the two new UI tests will be green

@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Jun 23, 2015
@mattab mattab added this to the 2.14.0 milestone Jun 23, 2015
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Jun 23, 2015
mattab pushed a commit that referenced this pull request Jun 23, 2015
Disallow api content to be loaded within Piwik
@mattab mattab merged commit 68dec5f into master Jun 23, 2015
@mattab mattab deleted the disallow_api branch June 24, 2015 01:54
@@ -333,6 +333,20 @@ describe("UIIntegrationTest", function () { // TODO: Rename to Piwik?
}, done);
});

// Do not allow API response to be displayed
it('should not allow to widgetize an API call', function (done) {
expect.screenshot('widgetize_apidisallowed').to.be.captureSelector('#content', function (page) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems to not work properly see https://travis-ci.org/piwik/piwik/jobs/68105052#L1337

Cannot find element #content

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 66511ac

mattab added a commit that referenced this pull request Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants