Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flat UI tweaks #8177

Merged
merged 2 commits into from Jun 23, 2015
Merged

More flat UI tweaks #8177

merged 2 commits into from Jun 23, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 22, 2015

We're using many different border colors and changed the border color of some components like Menu, Site Selector to be a bit lighter (looks nicer IMO) and more consistent with the other border colors. To see the differences you need to checkout the branch or try to see the difference by switching between processed and expected screenshot.

I also fixed one issue with spacing see eg http://builds-artifacts.piwik.org/ui-tests.flatten_ui/13616.7/UIIntegrationTest_admin_manage_users . There was a padding-top/bottom missing in entityTables and the text was not aligned correctly (padding-left). I had this change initially while working on #7090 but got lost somehow while making another change...

@tsteur tsteur added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Jun 22, 2015
@tsteur tsteur added this to the 2.14.0 milestone Jun 22, 2015
@mattab
Copy link
Member

mattab commented Jun 23, 2015

less variables use is more consistent, and it looks a bit better 👍

mattab pushed a commit that referenced this pull request Jun 23, 2015
@mattab mattab merged commit a8f5110 into master Jun 23, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 23, 2015
@mattab mattab deleted the flatten_ui branch June 24, 2015 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants