Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some parts of the available translations part of the API #8172

Closed
sgiehl opened this issue Jun 22, 2015 · 9 comments
Closed

Make some parts of the available translations part of the API #8172

sgiehl opened this issue Jun 22, 2015 · 9 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Milestone
Priority Backlog ...

Comments

@sgiehl
Copy link
Member

sgiehl commented Jun 22, 2015

Followup to #8101, refs #8125

We should make some parts of the translations part of the Piwik API.
Translations that are part of that API should never be changed and rarely be removed.

Part of that API should be all translation keys part of the Intl plugin as well as all keys in a special category that we need to define. We still need to consider which keys/translations should be added here.

We shall also update the developer docs to advice plugin developers, that those API translations can be used safely and that other translations available in Piwik might change in time.
That note should also be added to the translation search within Piwik
@sgiehl sgiehl added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. RFC Indicates the issue is a request for comments where the author is looking for feedback. labels Jun 22, 2015
@tsteur
Copy link
Member

tsteur commented Jun 23, 2015

👍

Don't have an opinion on the name of the second special category. Which keys are supposed to go into the Intl plugin? Only generic ones like dates etc or also analytics specific ones like "visits" and "website"? Maybe we could even just move all that are considered API into Intl?

@sgiehl
Copy link
Member Author

sgiehl commented Jun 24, 2015

Currently all translations available in the Intl plugin are extracted from CLDR and autogenerated. They are also NOT included on transifex.
I would not suggest to move any other translations to that plugin, as we would than need to include it on transifex.

@tsteur
Copy link
Member

tsteur commented Jun 24, 2015

Thx for clarification! Maybe it might be worth to add a README to this plugin explaining this?

@mattab
Copy link
Member

mattab commented Jul 15, 2015

👍

Which plugins translations are part of API, I guess Intl translations and also General?

@sgiehl maybe we add this as part of #8125 and close this RFC? (we will close #8125 later after creating a new public developer guide)

@mattab mattab added this to the 2.15.0 milestone Jul 15, 2015
@tsteur
Copy link
Member

tsteur commented Jul 15, 2015

I'd prefer to just remove the RFC label and add Enhancement or so. We need an issue to actually do this unless we're happy with the current translations in General and Intl @sgiehl ?

@sgiehl
Copy link
Member Author

sgiehl commented Jul 15, 2015

All Intl translations should be in the API. And I'd suggest to create a new category Piwik where we move translations we want to have in the API. Need to make some thoughts what we should move, but it should be stuff like metric names, general stuff like 'Yes', 'No', 'Cancel'

I'm not sure if we should do that for 2.15. Maybe 3.0 would be better for moving keys, as it might break translations for third party plugins using them

@tsteur
Copy link
Member

tsteur commented Jul 15, 2015

3.0 sounds good to me as it's not urgent and breaks things.

@mattab mattab modified the milestones: 3.0.0, 2.15.0 Jul 22, 2015
@mattab
Copy link
Member

mattab commented Aug 13, 2015

Once it's been decided to make some plugin translations part of the API, please update the list in: #8125

@sgiehl sgiehl removed their assignment Apr 28, 2020
@mattab
Copy link
Member

mattab commented Dec 10, 2023

Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Projects
None yet
Milestone
Priority Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @mattab @sgiehl