Refs #8060, fix bounce rate not appearing in legend or appearing incorrectly + some other bugs. #8171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calculating using bounce_count (which has to manually requested), and correctly format bounce_rate values in the legend. Bounce rate values must be converted to ints immediately after loading, since API.getProcessedReport will always format percents, and UserCountryMap uses them as if they are integers.
added 4 commits
June 22, 2015 02:33
…s if showRawMetrics is true. And correctly fdisplay and format avg_time_on_site using processed metric value, instead of recalculating in visitor map.
… will always revert to format_metrics=bc, since empty($request['format_metrics']) is used.
…ied to API.getProcessedReport. If not supplied, provide inconsistent but backwards compatible behavior.
…means getting numeric values from Piwik and formatting in JS, instead of getting intermediate metrics, calculating numeric metrics and then formatting in JS.
diosmosis
changed the title
|
Turned into a bigger PR than I anticipated, @mattab please review. BC should be maintained. |
added 3 commits
June 22, 2015 04:06
…t will format avg_price.
…tests, and re-use Fixture environment in ConsoleCommandTestCase.
|
@diosmosis could you add a UI test showing the bounce rate legend on the map? |
|
Looks good to me to merge after two UI tests added (one for bounce rate, one for average time on site) 👍 |
diosmosis
added a commit
that referenced
this pull request
Jun 23, 2015
Refs #8060, fix bounce rate not appearing in legend or appearing incorrectly + some other bugs.
diosmosis
pushed a commit
that referenced
this pull request
Jun 23, 2015
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Use bounce_rate metric directly in visitor map instead of… calculating using bounce_count (which has to manually requested), and correctly format bounce_rate values in the legend. Also, use avg_time_on_site metric directly, and format in JS properly.
Also includes a bug fix in Request.php: if
format_metrics=0is supplied, it will be overwritten toformat_metrics=bc, becauseif (empty($request['format_metrics']))is used, instead ofisset.To use unformatted (but computed) processed metrics in the visitor map, the code now formats the code itself in JS, at least for bounce_rate + avg_time_on_site. Bounce rate must be multiplied by 100. Average time on site just has to convert to a time string when being displayed.
Best to review commit by commit, paying attention to commit messages.