Wait for 400ms before capturing a screenshot #8167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Tests & QA
tsteur
force-pushed
the
wait_before_taking_screenshot
branch
from
249e812
to
4fb1f1c
Compare
… the whole page This could fix some random build failures
tsteur
force-pushed
the
wait_before_taking_screenshot
branch
from
4fb1f1c
to
4911a2d
Compare
|
We are not sure whether this really helps, so we will merge it and see what happens. If we still have as many random failures, we could revert this Pull request back. Refs #6693 |
mattab
pushed a commit
that referenced
this pull request
Jun 23, 2015
Wait for 400ms before capturing a screenshot
|
FYI: In case this does not work we could try to force a re-render before capturing a screenshot by increasing the window size by 1px. This could fix random issues as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because PhantomJS might just re-render the whole page as we changed the viewport size just before.
This could fix some random build failures