Reset viewport size after each UI test #8164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After one test set a viewPortSize, all following tests were executed with the same screenshot size. That means about 100 tests were actually executed with a screenshot size of 480x320
tsteur
added
c: Tests & QA
tsteur
added a commit
that referenced
this pull request
Jun 21, 2015
Reset viewport size after each UI test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After one test set a viewPortSize, all following tests were executed with the
same screenshot size. That means about 100 tests were actually executed with a
screenshot size of 480x320 because of https://github.com/piwik/piwik/blob/2.14.0-b4/tests/UI/specs/UIIntegration_spec.js#L76 a bit later on most tests were executed with a screenshot size of 320x320 by https://github.com/piwik/piwik/blob/master/tests/UI/specs/EvolutionGraph_spec.js#L146 causing failures like http://builds-artifacts.piwik.org/ui-tests.master/13496.7/Installation_db_setup