Improve unit tests #8150
Merged
Improve unit tests #8150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
added
c: Tests & QA
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of getting rid of
UnitTestCasethat sets up a complete environment, I have changed all tests that extend it:PHPUnit_Framework_TestCaseAs a result unit tests are much faster (not because there are less tests, but because there is never an environment set up. To give an idea a test class extending UnitTestCase would run in 2-5s, and without it would run in 100ms.
Locally unit tests have gone from 21s to 6s (no xdebug, no-globals-backup). Judging from travis integration tests are not longer.
The build is green, only UI tests are failing.