Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik 2.14.0-b4 package is 30Mb big instead of 14Mb #8144

Closed
mattab opened this issue Jun 19, 2015 · 6 comments
Closed

Piwik 2.14.0-b4 package is 30Mb big instead of 14Mb #8144

mattab opened this issue Jun 19, 2015 · 6 comments
Assignees
@mattab
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
2.14.0

Comments

@mattab
Copy link
Member

mattab commented Jun 19, 2015

Between beta1 and beta2 the Piwik ZIP package grew 15Mb / 100% to 30Mb. See:

regressed size

let's investigate and make package smaller again, 30Mb is not reasonable.
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 19, 2015
@mattab mattab added this to the 2.14.0 milestone Jun 19, 2015
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Jun 19, 2015
@diosmosis
Copy link
Member

The tests folder is 24MB, should it be in betas?

@mnapoli
Copy link
Contributor

mnapoli commented Jun 19, 2015

TCPDF is now installed with Composer (was previously included in the repo manually IIRC): https://github.com/piwik/piwik/blob/master/composer.json#L58

This dependency includes 27Mb of fonts. I guess that explains the difference. I don't know if we use them though, might require to carefully remove them. Also there are 2Mb of examples in there that we can get rid of.

@mattab mattab mentioned this issue Jun 20, 2015
Closed
@mattab
Copy link
Member Author

mattab commented Jun 20, 2015

The tests folder is 24MB, should it be in betas?

all files in tests/* are deleted from the releases

This dependency includes 27Mb of fonts. I guess that explains the difference.

That explains it!! we will need to update the build script https://github.com/piwik/piwik-package/blob/master/scripts/build-package.sh to remove unused fonts cc @sgiehl in case you know which ones we need

Also created a follow up issue: automated test to detect when the Piwik files become too big #8158

@sgiehl
Copy link
Member

sgiehl commented Jun 20, 2015

See https://github.com/piwik/piwik/blob/master/core/ReportRenderer/Pdf.php#L93-L132
I guess all existing variants of the font we use here, could be removed aswell.

@mattab mattab self-assigned this Jun 22, 2015
@mattab mattab mentioned this issue Jun 22, 2015
Closed
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jun 22, 2015
@mattab
Copy link
Member Author

mattab commented Jun 22, 2015

done in: matomo-org/matomo-package#33 (comment)

2.14.0-b6 is back to being 16M 👍

refs #7908

@mattab mattab closed this as completed Jun 22, 2015
@mattab
Copy link
Member Author

mattab commented Jun 22, 2015

it's still 3Mb bigger than 2.13.1 but after looking hard I can't find any more way to make package size smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
4 participants
@diosmosis @mattab @mnapoli @sgiehl