Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Dashboard UI tests #8142

Closed
mattab opened this issue Jun 18, 2015 · 0 comments
Closed

Re-enable Dashboard UI tests #8142

mattab opened this issue Jun 18, 2015 · 0 comments
Assignees
@tsteur
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.14.0

Comments

@mattab
Copy link
Member

mattab commented Jun 18, 2015

After hours and days of investigating and improving our screenshot tests, still we had issues with a few tests and had to disable them in #8117

The goal of this issue is to re-enable those dashboard tests at some point. Maybe phantomjs 2.0 would be more memory efficient and it could help?
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Jun 18, 2015
This was referenced Jun 18, 2015
Merged
Closed
@tsteur tsteur mentioned this issue Jun 21, 2015
Merged
tsteur added a commit that referenced this issue Jun 22, 2015
@tsteur
refs #8142 Compare images with ImageMagick instead of resemble
9f94010 
It looks like resemble causes the random crashes during UI tests
on Travis CI. I can reproduce this locally and identified resemble
as the problem. The tests crashed because of too much memory usage
We now also avoid loading the images into PhantomJS to compare
them. By executing ImageMagick we seem to save a lot of memory and
time. Eg currently on master the tests need more than 50
minutes whereas with this solution it takes only approx 37 minutes.
@tsteur tsteur self-assigned this Jun 22, 2015
@tsteur tsteur added this to the 2.14.0 milestone Jun 22, 2015
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@tsteur @mattab