Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When segment sub-expression does not match any action, replace the SQL WHERE statement by (1 = 0) #8133

Merged
merged 3 commits into from Jun 18, 2015
Merged

When segment sub-expression does not match any action, replace the SQL WHERE statement by (1 = 0) #8133

merged 3 commits into from Jun 18, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented Jun 18, 2015

  • first we add some integration tests for the SQL generator to cover existing logic: abefede
  • then we fix the bug and the tests show that SQL becomes simpler, and therefore should be faster
  • then System tests helped me find a bug fixed in: 1b87342

fixes #8102

@mattab
Add integration tests for Segmented SQL query generator
abefede
@mattab
when we know a segment won't match any row, replace the SQL sub-expre…
937e73d 
…ssion by (1 = 0)

Segment SQL generator: un-needed joins on log_link_visit_action  are removed, making the query a bit faster
@mattab
Fixes a bug where the segment operator is !=
1b87342
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 18, 2015
@mattab mattab added this to the 2.14.0 milestone Jun 18, 2015
mattab pushed a commit that referenced this pull request Jun 18, 2015
Merge pull request #8133 from piwik/8102_slow_sql_query
be138da 
When segment sub-expression does not match any action, replace the SQL WHERE statement by (1 = 0)
@mattab mattab merged commit be138da into master Jun 18, 2015
@diosmosis diosmosis deleted the 8102_slow_sql_query branch June 19, 2015 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattab