Make sure BulkTracking skips requests for nonexistant sites. #8132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Bug
|
Related PR for QueuedTracking: matomo-org/plugin-QueuedTracking#9 |
|
@tsteur Could you review this + the QueuedTracking build when you can? |
| @@ -13,6 +13,9 @@ This is a changelog for Piwik platform developers. All changes for our HTTP API' | |||
| ### Library updates | |||
| * Updated pChart library from 2.1.3 to 2.1.4. The files were moved from the directory `libs/pChart2.1.3` to `libs/pChart` | |||
|
|
|||
| ### Other | |||
| * During bulk tracking, if a request references a non-existant website, it will be skipped. So bulk tracking requests with one or more of these will succeed where they would have failed before. The number of skipped requests is now reported in bulk tracking responses. | |||
There was a problem hiding this comment.
Should we maybe list it as "breaking change"? It doesn't break code but in terms of functionality? "Breaking change" is maybe too negative though since it is rather a fix. Actually: I'm not sure if we need to list it here at all. It's not really code / platform related. This is more an important notice in the regular changelog since it can change quite a lot for some people (in a good way I think)
|
I'd personally remove the changelog entry but otherwise 👍 |
added 2 commits
June 22, 2015 03:48
…requests will still be tracked. Includes new tests in BulkTracking plugin.
…elopers see changes.
diosmosis
force-pushed
the
bulk_track_ignore_errors
branch
from
106c053
to
f7a0c26
Compare
|
@tsteur Removed changelog entry + switched to invalid. |
diosmosis
added a commit
that referenced
this pull request
Jun 22, 2015
Make sure BulkTracking skips requests for nonexistant sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
This is to fix matomo-org/matomo-log-analytics#73
Since log importing uses bulk tracking, individual requests cannot be skipped in the python script, so the bug cannot be fixed in the script.