Make the installation of Piwik work with HHVM. #8131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with the issue #8108 on checking the loaded extensions, this pull request changes the check functions (ie in_array and get_extensions_loaded) by extension_loaded which is case insensitive.
This occurred in the systemCheck action for files PhpExtensionsCheck.php and DbAdapterCheck.php and in the databaseSetup action for files Mssql.php, Pgsql.php and Mysql.php.
This request also fixes a verification problem of the directive "always_populate_raw_post_data" which is considered as a boolean by HHVM (see http://docs.hhvm.com/manual/en/ini.core.php#ini.always-populate-raw-post-data).
Below are two screenshots showing the result before and after. You may also notice that the verification of the Reflection extension is present again (They are in french but the name of the extensions doesn't change).