Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the installation of Piwik work with HHVM. #8131

Merged
merged 2 commits into from Jun 18, 2015
Merged

Make the installation of Piwik work with HHVM. #8131

merged 2 commits into from Jun 18, 2015

Conversation

Loscillo
Copy link
Contributor

In conjunction with the issue #8108 on checking the loaded extensions, this pull request changes the check functions (ie in_array and get_extensions_loaded) by extension_loaded which is case insensitive.

This occurred in the systemCheck action for files PhpExtensionsCheck.php and DbAdapterCheck.php and in the databaseSetup action for files Mssql.php, Pgsql.php and Mysql.php.

This request also fixes a verification problem of the directive "always_populate_raw_post_data" which is considered as a boolean by HHVM (see http://docs.hhvm.com/manual/en/ini.core.php#ini.always-populate-raw-post-data).

Below are two screenshots showing the result before and after. You may also notice that the verification of the Reflection extension is present again (They are in french but the name of the extensions doesn't change).

piwik_hhvm_before

piwik_hhvm

[Fix] HHVM returns name of loaded extensions in lowercase. Replacing functions in_array and get_loaded_extensions by extension_loaded which is case insensitive.
[Fix] HHVM defines the directive "always_populate_raw_post_data" as a boolean and therefore can not accept the value -1. Thus, when using HHVM, the check is not performed.
@mattab mattab added this to the 2.14.0 milestone Jun 18, 2015
@mattab mattab changed the title Fixes the installation of Piwik with HHVM. Make the installation of Piwik work with HHVM. Jun 18, 2015
@mattab
Copy link
Member

mattab commented Jun 18, 2015

Thanks @Loscillo for the pull request and improving HHVM support in Piwik #4415

mattab pushed a commit that referenced this pull request Jun 18, 2015
Make the installation of Piwik work with HHVM.
@mattab mattab merged commit 8ef0e16 into matomo-org:master Jun 18, 2015
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants