Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent passwords in config file #8130

Closed
quba opened this issue Jun 17, 2015 · 6 comments
Closed

Consistent passwords in config file #8130

quba opened this issue Jun 17, 2015 · 6 comments
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@quba
Copy link
Contributor

quba commented Jun 17, 2015

If we have a password to the DB like something&else Piwik stores it in config file as something&else. Is there something we can do with it? Piwik is able to connect to the DB but it's problematic for administrators when they want to use a password that is available in the config file. And of course it may be really confusing sometimes.
@mnapoli
Copy link
Contributor

mnapoli commented Jun 17, 2015

For the record I believe this is related to this piece of code which uses htmlentities(): https://github.com/piwik/piwik/blob/master/core/Config/IniFileChain.php#L422-L423

@tsteur
Copy link
Member

tsteur commented Jun 17, 2015

Maybe also see #5349
#341
#5409

I think it was due to security reasons and to prevent possible errors. I don't remember the exact reasons anymore. I was confused by this initially as well but afterwards it made sense and I think I remember there was no way around this and we had to keep this behaviour I think. Maybe it's different now

@mattab
Copy link
Member

mattab commented Jun 17, 2015

and also #7673 #690 #2968

I suggest it's "wontfix / cant fix"

@mattab mattab closed this as completed Jul 15, 2015
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Jul 15, 2015
@mattab
Copy link
Member

mattab commented Jul 15, 2015

"Wontfix" to prevent a lot of pain (and I don't think it can even be fixed due to INI file limitations)

@mattab
Copy link
Member

mattab commented Jul 15, 2015

@quba if we need to read password from config file, we could maybe create a console command that outputs the password so it prevents confusion and error. such command would be trivial to add.

@mattab
Copy link
Member

mattab commented Jul 15, 2015

the command could even output the full mysql command to connect to the DB, with username, db name, password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsteur @mattab @quba @mnapoli