Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom variables report bug - missing visits sum #8128

Closed
dczajkacc opened this issue Jun 17, 2015 · 4 comments
Closed

Custom variables report bug - missing visits sum #8128

dczajkacc opened this issue Jun 17, 2015 · 4 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. c: Website matomo.org For issues related to our matomo.org website. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.16.0

Comments

@dczajkacc
Copy link

Sum for custom variable in page scope is missing, see screenshot:
ean
ean - page scope
languageCode - visit scope

Another problem but maybe the same bug:
image001
selected variables were tracked on every page, so actions should be "9" for all three.

Was confirmed on piwik 2.9.1 and 2.13
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jul 15, 2015
@mattab
Copy link
Member

mattab commented Jul 15, 2015

Hi @dczajkacc

Thanks for the report.

By design:

  • Custom variables of 'visit' scope: it is expected that these ones have the "visit" column set
  • Custom variables of 'page' scope: we cannot process "Visits" count for these.
    • Why? we process "Actions" column with a SELECT count(*). A same visit can set the same custom variable of 'page' scope multiple times. We cannot sum the values of count(*) as it would be incorrect. the way we could process "Visits" Metric for 'page' scope variable is to issue a count(Distinct *) or so, but it is no implemented yet (this would likely be very slow for high traffic sites). it was part of initial design that we do not issue the count(distinct *) query and that's why we do not show "Visits" metric for 'page' scope variable.
    • The code that removes those metrics is in: https://github.com/piwik/piwik/blob/2.14.0/plugins/CustomVariables/Archiver.php#L213-226

Therefore it is working as expected 👍

Another problem but maybe the same bug:

it's not the same bug, could you create a new issue with steps to reproduce? we will investigate.

@mattab mattab closed this as completed Jul 15, 2015
@mattab
Copy link
Member

mattab commented Jul 15, 2015

Reopening - as I think we should document this behavior in the user or developer guides somewhere to prevent confusion in other users as well!

@mattab mattab reopened this Jul 15, 2015
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Website matomo.org For issues related to our matomo.org website. and removed Bug For errors / faults / flaws / inconsistencies etc. labels Jul 15, 2015
@mattab mattab added this to the 2.15.0 milestone Jul 15, 2015
@mattab mattab self-assigned this Aug 10, 2015
@mattab mattab modified the milestones: 2.15.1, 2.15.0 Sep 22, 2015
mattab added a commit that referenced this issue Jan 7, 2016
@mattab
Adding comment to clarify logic refs #8128 (comment)
448fe33
@mattab
Copy link
Member

mattab commented Jan 11, 2016

It would be useful to document this behavior directly in the UI (in report footer maybe?) , or visibly link to the help information, when this use case actually occurs (ie. when there are custom variable rows that do not have visits metrics but have actions metrics).

@mattab mattab removed their assignment Jan 14, 2016
mattab added a commit that referenced this issue Jan 27, 2016
@mattab
Display a footer message below report which explains why some metrics…
d604885 
… are not set

 Goal: minimise user confusion and support requests.
 The message is only displayed when the report table contains Custom Variable of scope 'page'.
 If the report only contains Custom Variable of scope 'visit' the message won't be shown.
Fixes  #8128
@mattab mattab mentioned this issue Jan 27, 2016
Merged
@mattab
Copy link
Member

mattab commented Jan 27, 2016

PR: #9643

@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Jan 30, 2016
sgiehl pushed a commit to matomo-org/plugin-CustomVariables that referenced this issue Jun 18, 2020
@mattab
Adding comment to clarify logic refs matomo-org/matomo#8128 (comment)
9250c5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. c: Website matomo.org For issues related to our matomo.org website. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@mattab @dczajkacc