Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should fix recoverable error missing $dataAccess parameter #8116

Merged
merged 2 commits into from Jun 16, 2015
Merged

Should fix recoverable error missing $dataAccess parameter #8116

merged 2 commits into from Jun 16, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 16, 2015

To reproduce go to Administration -> Privacy then click on another page. You should see the following error:

WARNING: /home/piwik-demo2/www/plugins/DBStats/MySQLMetadataProvider.php(43): Notice - Undefined variable: dataAccess - Piwik 2.14.0-b2 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)
×WARNING: /home/piwik-demo2/www/plugins/DBStats/MySQLMetadataProvider.php(41): Recoverable Error - Argument 1 passed to Piwik\Plugins\DBStats\MySQLMetadataProvider::__construct() must be an instance of Piwik\Plugins\DBStats\MySQLMetadataDataAccess, none given, called in /home/piwik-demo2/www/plugins/PrivacyManager/Controller.php on line 194 and defined - Piwik 2.14.0-b2 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 16, 2015
@tsteur tsteur added this to the 2.14.0 milestone Jun 16, 2015
@tsteur tsteur added Needs Review PRs that need a code review and removed Bug For errors / faults / flaws / inconsistencies etc. labels Jun 16, 2015
diosmosis added a commit that referenced this pull request Jun 16, 2015
@diosmosis
Merge pull request #8116 from piwik/fix_missing_dataaccess_parameter
f7cc14a 
Recoverable error missing $dataAccess parameter when creating MySQLMetadataProvider in PrivacyManager controller. Fix by using DI.
@diosmosis diosmosis merged commit f7cc14a into master Jun 16, 2015
@diosmosis diosmosis deleted the fix_missing_dataaccess_parameter branch June 16, 2015 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis