Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Dependencies case sensitive in HHVM #8108

Closed
Loscillo opened this issue Jun 15, 2015 · 3 comments
Closed

PHP Dependencies case sensitive in HHVM #8108

Loscillo opened this issue Jun 15, 2015 · 3 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.14.0

Comments

@Loscillo
Copy link
Contributor

Hi,

I wanted to install Piwik on my machine running HHVM. I was very surprised when I saw that PDO and SPL were not active on my version.

However, after some checking, it seems that my version of HHVM (I do not know if this is common to all versions of HHVM or may occur with a standard PHP) returns both extensions in lowercase.

The problem is the in_array function that is used in the following files:

  • plugins/Diagnostics/Diagnostic/PhpExtensionsCheck.php for SPL.
  • plugins/Diagnostics/Diagnostic/DbAdapterCheck.php for PDO.

Moreover, it seems that HHVM does not support -1 for directive always_populate_raw_post_data (shown as boolean on http://docs.hhvm.com/manual/en/ini.core.php#ini.always-populate-raw-post-data, possibility of putting 0 but not -1, check is in plugins/Diagnostics/Diagnostic/DbAdapterCheck.php).

Thank you in advance for solving these problems,
Have a nice day.
@mattab
Copy link
Member

mattab commented Jun 16, 2015

Hi @Loscillo

Thanks for feedback. Currently we don't offer official support for HHVM.

We welcome pull requests from the community! please consider opening pull request to add HHVM support. See also #7555 #4415

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 16, 2015
@Loscillo
Copy link
Contributor Author

Hi,

Thank you for your reply. I do it when I have enough time and connection.

Have a nice day.

@Loscillo Loscillo mentioned this issue Jun 17, 2015
Merged
@mattab mattab changed the title PHP Dependencies case sensitive (HHVM only ?) PHP Dependencies case sensitive in HHVM Jun 18, 2015
@mattab mattab added this to the 2.14.0 milestone Jun 18, 2015
@mattab
Copy link
Member

mattab commented Jun 18, 2015

@Loscillo I believe you fixed it in #8131 👍

feel free to re-open in case there is still some work to do

@mattab mattab closed this as completed Jun 18, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@mattab @Loscillo