Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mocha + chai for piwik.js tests instead of qunit #8097

Closed
diosmosis opened this issue Jun 12, 2015 · 1 comment
Closed

Use mocha + chai for piwik.js tests instead of qunit #8097

diosmosis opened this issue Jun 12, 2015 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@diosmosis
Copy link
Member

Using qunit's strange async code is both painful and remarkably confusing.

mocha results in very easy to read test files, even when asynchronous code needs to be tested. And we already include mocha + chai for UI tests, so we wouldn't have to add any libs.
@diosmosis diosmosis added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 12, 2015
@diosmosis diosmosis added this to the 3.0.0 milestone Jun 12, 2015
@mattab mattab modified the milestones: Short term, 3.0.0 Aug 13, 2015
@mattab mattab removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 13, 2015
@mattab
Copy link
Member

mattab commented Jul 8, 2016

This probably will happen in the future whenever it will be needed.

@mattab mattab closed this as completed Jul 8, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Jul 8, 2016
@Findus23 Findus23 mentioned this issue Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@diosmosis @mattab