Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fix for recent DI change #8095

Merged
merged 2 commits into from Jun 12, 2015
Merged

Build fix for recent DI change #8095

merged 2 commits into from Jun 12, 2015

Conversation

diosmosis
Copy link
Member

Includes two changes:

  • Determine plugins to load in tests through TestingEnvironmentManipulator instead of in manual call to Fixture::loadPlugins.
  • Make sure FakeAccess::reloadAccess returns true to signal successful reload.

diosmosis added 2 commits June 11, 2015 19:14
Load plugins in tests automatically through testing environment manip…
a73f710 
…ulation, instead of through a method in Fixture. Allows plugin environment configs to be loaded during tests.
Make sure FakeAccess::reloadAccess() returns true, indicating success…
9ca33d8 
…ful reloading.
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 12, 2015
@diosmosis diosmosis self-assigned this Jun 12, 2015
@diosmosis diosmosis added this to the 2.14.0 milestone Jun 12, 2015
diosmosis added a commit that referenced this pull request Jun 12, 2015
@diosmosis
Merge pull request #8095 from piwik/plugins_in_tests
1f53f4b 
Build fix for recent DI change. Determine plugins to load in tests through TestingEnvironmentManipulator instead of manual call to Fixture::loadPlugins & fix FakeAccess.
@diosmosis diosmosis merged commit 1f53f4b into master Jun 12, 2015
@diosmosis diosmosis deleted the plugins_in_tests branch June 12, 2015 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@diosmosis diosmosis

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diosmosis