Small visual change in the visitor log (mainly for UI tests) #8090
Conversation
…'s visually better and it will not cause screenshot tests to randomly fail
mnapoli
added
c: Tests & QA
|
I tried the branch and it does not look quite good to have two rows of icon above each other I think One way to make the visitor log look nice is to redesign it, in #7909. Maybe we could use the card design like was done in #8002 and change the layout a bit. (maybe the visitor log could look bit more consistent with Visitor Profile?) If we want to solve the random test UI while waiting for #7909 maybe you could put the icon Flag+Returning visitor in the left column, below all other user metadata, left aligned with same spacing as other text lines. (quickly tried it and it looked good imho) |
mattab
added
the
not-in-changelog
|
OK will try that! |
…void random failures in UI tests
|
Updated to this:
Is that what you meant @mattab? |
|
Yes it's better this way.. Feedback: we need to have the same space on top and bottom of the icons. Got: less margin on top than on bottom. Expected: more space on top of icons? PS: do you think it will solve the random UI test failure? IIRC the UI test fails because of the "Goal conversion / ecommerce" block positioning and this block hasn't moved. But maybe i'm wrong and just moving the flag + returning icons, will fix it 👍 |
|
It's the same space as it is today, it's like "paragraphs"… |
|
In general in Piwik there are many issues with spacing, so it's nice to leave things better than when we found. I pointed this one out because it would be nice to slowly fix those inconsistent spacing issues everywhere. Tomorrow with @tsteur we'll take a look at spacing in the UI especially around titles. Feel free to skip this if you don't care, as it's not a new issue |
I just want to try and fix tests because it's a huge pain every single day. I want to move forward, those back and forth only kill the motivation to tackle those long-standing side-issues. |
Small visual change in the visitor log (mainly for UI tests)
|
Sure I got carried away, let's get moving and stay focused on your goal here which is fixing a UI test 👍 |
Changed slightly the position of icons in the visitor log so that it's visually a little better and it will not cause screenshot tests to randomly fail (at least that's what I hope…).
Basically what I've done is remove the float left/float right for the 2 groups of icons and instead display them on top of one another.
You can see the diff here: http://builds-artifacts.piwik.org/ui-tests.fix-ui-tests-visitor-log/13240.7/screenshot-diffs/diffviewer.html
Before
After