Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover displaying messages should use Piwik design style #8087

Closed
mattab opened this issue Jun 11, 2015 · 2 comments
Closed

Popover displaying messages should use Piwik design style #8087

mattab opened this issue Jun 11, 2015 · 2 comments
Assignees
@mnapoli
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
2.14.0

Comments

@mattab
Copy link
Member

mattab commented Jun 11, 2015

Reproduce:

popover no permission
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jun 11, 2015
@mattab mattab added this to the 2.14.0 milestone Jun 11, 2015
mattab added a commit that referenced this issue Jun 23, 2015
@mattab
Throw a NoAccessException when the user does not have needed access
2f34a93 
refs #8087
@mattab
Copy link
Member Author

mattab commented Jun 23, 2015

The popover now displays the un-styled login form:

un-styled login form

Goal of this issue is to either:

  • when the popover displays a login form, redirect the whole page to the login form (easy fix?)
  • or style the form within the popover (likely not easy / not really needed?)

mnapoli added a commit that referenced this issue Jun 23, 2015
@mnapoli
#8087 show error formatted nicely when it happens in an AJAX request …
0cf1ebc 
…(e.g. popovers)
mnapoli added a commit that referenced this issue Jun 23, 2015
@mnapoli
#8087 handle also the cases where a user has no access (redirect to t…
fba961d 
…he login form)
@mnapoli mnapoli mentioned this issue Jun 23, 2015
Merged
@mnapoli mnapoli self-assigned this Jun 23, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Jun 23, 2015

PR: #8184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@mattab @mnapoli