@sgiehl a couple System tests are failing, here is some background info:
setBrowserLanguageon the fixture visits, then the test may pass
Can you maybe try to add
$dataTable->filter('AddSegmentValue'); similar as done here: https://github.com/piwik/piwik/blob/master/plugins/DevicesDetection/API.php#L237 in
UserLanguage\API for those reports?
This might add the "One-click-segment feature" to those reports. If it works you will see in the language report on row hover an icon that opens a popup showing the visitor log with all the users having the same language. Unfortunately, we still have to add this manually each time. It's not guaranteed it works as easy as that though. If not, we could create a new issue to add it for those reports.
@sgiehl I found a minor issue, see previous comment.
Ok. I'll have a look
I've checked that and push it to master later. Correct segment is
languageCode==fr,languageCode=<a class='mention' href='https://github.com/fr'>@fr</a>- to avoid matches for language codes like
Correct segment is
languageCode==fr,languageCode=<a class='mention' href='https://github.com/fr'>@fr</a>-to avoid matches for language codes like
oh that's smart! :+1:
Should be in 2.14 or in any of the latest beta versions
@mgonera Here is a useful github trick. if you click on the commit, you will arrive on commit page. there Github shows which tag already contains this commit. For this particular commit you can see:
-> this change is available since 2.14.0-b4
Note: the new segment is actually
languageCode. Added to developer changelog in https://github.com/piwik/piwik/commit/980c12bbe40f1225a895da1f4efa4d1d3d4dcd0c