@sgiehl opened this Pull Request on June 10th 2015 Member

fixes #3950

@mattab commented on June 11th 2015 Member

@sgiehl a couple System tests are failing, here is some background info:

@sgiehl commented on June 12th 2015 Member

@mattab system tests are ok now

@tsteur commented on June 15th 2015 Member

Can you maybe try to add $dataTable->filter('AddSegmentValue'); similar as done here: https://github.com/piwik/piwik/blob/master/plugins/DevicesDetection/API.php#L237 in UserLanguage\API for those reports?

This might add the "One-click-segment feature" to those reports. If it works you will see in the language report on row hover an icon that opens a popup showing the visitor log with all the users having the same language. Unfortunately, we still have to add this manually each time. It's not guaranteed it works as easy as that though. If not, we could create a new issue to add it for those reports.

@sgiehl commented on June 15th 2015 Member

@tsteur seems to work

@tsteur commented on June 15th 2015 Member

:+1:

@mattab commented on June 16th 2015 Member

@sgiehl I found a minor issue, see previous comment.

otherwise :+1:

@sgiehl commented on June 16th 2015 Member

Ok. I'll have a look

@sgiehl commented on June 16th 2015 Member

I've checked that and push it to master later. Correct segment is languageCode==fr,languageCode=<a class='mention' href='https://github.com/fr'>@fr</a>- to avoid matches for language codes like de-fr

@mattab commented on June 17th 2015 Member

Correct segment is languageCode==fr,languageCode=<a class='mention' href='https://github.com/fr'>@fr</a>- to avoid matches for language codes like de-fr

oh that's smart! :+1:

@mgonera commented on June 25th 2015

@mattab @sgiehl Please confirm if this will be included in 2.14 or in which other version?

@sgiehl commented on June 25th 2015 Member

Should be in 2.14 or in any of the latest beta versions

@mattab commented on June 25th 2015 Member

@mgonera Here is a useful github trick. if you click on the commit, you will arrive on commit page. there Github shows which tag already contains this commit. For this particular commit you can see:
commit

-> this change is available since 2.14.0-b4

@mgonera commented on June 26th 2015

@mattab very cool, thanks! this for sure will come in handy

@mattab commented on June 26th 2015 Member

Note: the new segment is actually languageCode. Added to developer changelog in https://github.com/piwik/piwik/commit/980c12bbe40f1225a895da1f4efa4d1d3d4dcd0c

This Pull Request was closed on June 15th 2015
Powered by GitHub Issue Mirror