@sgiehl a couple System tests are failing, here is some background info:

• this system test AutoSuggestAPITest is testing that all segments work
• it tests that the "Auto complete suggests" will return values for that segment
• for the segment to have "auto complete suggestions" we need to track visits with segment values in the test fixture. the fixture is: https://github.com/piwik/piwik/blob/master/tests/PHPUnit/Fixtures/ManyVisitsWithGeoIP.php#L191-191 - maybe if you edit it to set setBrowserLanguage on the fixture visits, then the test may pass

@mattab system tests are ok now

Can you maybe try to add $dataTable->filter('AddSegmentValue'); similar as done here: https://github.com/piwik/piwik/blob/master/plugins/DevicesDetection/API.php#L237 in UserLanguage\API for those reports?

This might add the "One-click-segment feature" to those reports. If it works you will see in the language report on row hover an icon that opens a popup showing the visitor log with all the users having the same language. Unfortunately, we still have to add this manually each time. It's not guaranteed it works as easy as that though. If not, we could create a new issue to add it for those reports.

@tsteur seems to work

👍

@sgiehl I found a minor issue, see previous comment.

otherwise 👍

Ok. I'll have a look

I've checked that and push it to master later. Correct segment is languageCode==fr,languageCode=@fr- to avoid matches for language codes like de-fr

Correct segment is languageCode==fr,languageCode=@fr- to avoid matches for language codes like de-fr

oh that's smart! 👍

@mattab @sgiehl Please confirm if this will be included in 2.14 or in which other version?

@mgonera Here is a useful github trick. if you click on the commit, you will arrive on commit page. there Github shows which tag already contains this commit. For this particular commit you can see:

-> this change is available since 2.14.0-b4

@mattab very cool, thanks! this for sure will come in handy

Note: the new segment is actually languageCode. Added to developer changelog in 980c12b