Fixes #7912, add --force-idsegments parameter and --skip-all-segments parameter to core:archive command. #8080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Enhancement
mattab
added
the
not-in-changelog
|
There are some tests failing. Do you mind having a look whether it is caused by this PR? Just for understanding: Was the only reason to add this to save 10 seconds or other things as well? |
The issue is to fix #7912, that's the main reason for this PR. The test change was just so my additional test wouldn't result in a longer test run. Will look at the build failure now. |
added 4 commits
June 15, 2015 19:38
…e parameter in CronArchive.php class. New parameter limits list of segments that should be archived during archiving, all other segments are skipped.
…ipping archiving of segments.
diosmosis
force-pushed
the
7912_archiving_segments
branch
from
b0f0eda
to
32ea9e5
Compare
|
The build failure was due to a bug, should be fixed in the code I pushed. |
tsteur
added a commit
that referenced
this pull request
Jun 16, 2015
Fixes #7912, add --force-idsegments parameter and --skip-all-segments parameter to core:archive command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Also includes a change to CronArchive/CronArchiveTest.php which allows using a mock CliMulti instance with CronArchive. Speeds CronArchiveTest.php by ~10s.
Refs #7912