Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent message "could not find layer regions" when clicking on "Cities" in VisitorMap #8073

Merged
merged 1 commit into from Jun 15, 2015
Merged

Prevent message "could not find layer regions" when clicking on "Cities" in VisitorMap #8073

merged 1 commit into from Jun 15, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 9, 2015

refs #8061

See issue. Not sure re any side effects but it stops triggering the console.warn (or alert on IE 8) and "seems" to work

@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 9, 2015
@tsteur tsteur added this to the 2.14.0 milestone Jun 9, 2015
@tsteur tsteur changed the title This might prevent a message "could not find layer regions" Prevent message "could not find layer regions" when clicking on "Cities" in VisitorMap Jun 9, 2015
@andrzejewsky
Copy link

Hi @tsteur look at this screen:
zrzut ekranu 2015-06-09 o 15 42 29

Just change 190 line to (then we will have 0 instead of NaN):

v = formatNumber(Math.round(val || 0)) + (metric == 'avg_time_on_site' ? first ? ' sec' : 's' : '');

Or maybe in this case legend should not appear ? (line 209)

if (stats.min == stats.max && typeof stats.min != 'undefined')

@tsteur
Copy link
Member Author

tsteur commented Jun 9, 2015

I'm not sure but this looks like a complete different issue. I'm not even sure how you managed to open South Africa without having a visitor there? Do you mind creating an issue or pull request for this with steps to reproduce this?

@diosmosis
Copy link
Member

Looks ok, can't find any issue. Would be nice if we could eventually refactor the map code.

diosmosis added a commit that referenced this pull request Jun 15, 2015
@diosmosis
Merge pull request #8073 from piwik/8061
873470f 
Prevent message "could not find layer regions" when clicking on "Cities" in VisitorMap,
@diosmosis diosmosis merged commit 873470f into master Jun 15, 2015
@diosmosis diosmosis deleted the 8061 branch June 15, 2015 21:57
@tsteur
Copy link
Member Author

tsteur commented Jun 15, 2015

Looks ok, can't find any issue. Would be nice if we could eventually refactor the map code.

Yep and update to the latest version of Kartograph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @andrzejewsky @diosmosis