Track optionally downloads and outlinks for middle clicks and open context menu #8068
Conversation
| } | ||
| } else if (evt.type === 'mouseup') { | ||
| if (button === lastButton && target === lastTarget) { | ||
| } else if (event.type === 'contextmenu') { | ||
| processClick(target); |
There was a problem hiding this comment.
It's important to know that when the contextmenu event is triggered, a click event is not triggered. At least in all the browsers that I tested. This is important as we would otherwise track a click multiple times. There is a certain risk if a browser changes this behaviour or if a browser is buggy that we track multiple times.
tsteur
added
not-in-changelog
|
In case someone is wondering how I tested on Saucelabs: First of all: It was a manual test, not an automated test. What I did was to create a standalone, plain html file and uploaded it on a server. That html file contained only the |
|
Looks ok to me, will merge after some manual testing. |
Fixes #5287, track optionally downloads and outlinks for middle clicks, opening context menus and ctrl/command clicks.
fixes #5287 as discussed in the issue.
There was already an opt-in flag called
enabledto track middle clicks (I think it did not work properly BTW). I reused this one to also track "opened context menu". To use this new feature usetracker.enableLinkTracking(true)or_paq.push(['enableLinkTracking', true]);We can later change the default from
enabled=falsetoenabled=true.enabled=truewas set. I kinda doubt it worked since it did not consider some browser incompatibilities but there's a chance it did work. Anyway, "middle clicks" should be now tracked more accurately.right click, orctrl+left clickon Mac,metaKey+leftclick on Windows, ...)ctrl+ left clickon Windows,metaKey+left clickon Mac). It should work at least in Firefox and Chrome. It didn't work in IE10I tested in many browsers (on Saucelabs) and on some phones and it should work but one can never tell re different browser behaviour. It should be pretty safe to merge though.