Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segmentation fault caused by Dashboard_spec.js in travis + related changes #8067

Merged
merged 4 commits into from Jun 9, 2015
Merged

Fix segmentation fault caused by Dashboard_spec.js in travis + related changes #8067

merged 4 commits into from Jun 9, 2015

Conversation

diosmosis
Copy link
Member

Includes the following changes:

  • Switch to evaluating JavaScript in the offending test in Dashboard_spec.js instead of sending events through qtwebkit (which appears to cause the seg fault in this case).
  • Fix a bug in UserCountryMap, where for some reason in the widgetized dashboard, the UserCountry functions.php file is not loaded (at least for the test) and so one of the functions used is not available.
  • In ajaxHelper, decrement the active number of AJAX requests on request error.
  • In the event of a page loading timeout, display the number of pending AJAX requests, loading images & whether the page is ready or not for better debugging.

NOTE: This will cause some failures in the Dashboard spec. These failures occur because the current test is broken, some of the expected screenshots are wrong.

Refs #7147

diosmosis added 4 commits June 8, 2015 17:43
On AJAX error, decrement active requests in global ajax queue so erro…
201e528 
…rs that occur during UI tests do not timeout.
Require UserCountry functions.php file in UserCountryMap so UI tests …
a03be36 
…won't fail (a request from the widgetized dashboard to the UserCountryMap failed because a function in this file was not available).
Fix segmentation fault caused by Dashboard_spec.js by executing JS in…
a7a2095 
… page instead of sending actual events to qtwebkit. This change fixes the Dashboard UI tests which appear to have been broken for a long time.
Add some debug info to page loading timeout in screenshot testing lib.
d9278fa
@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Jun 9, 2015
@diosmosis diosmosis added this to the 2.14.0 milestone Jun 9, 2015
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 9, 2015
mattab pushed a commit that referenced this pull request Jun 9, 2015
Merge pull request #8067 from piwik/fix-ui-tests-again
f34dd5f 
Fix segmentation fault caused by Dashboard_spec.js in travis + related changes
@mattab mattab merged commit f34dd5f into master Jun 9, 2015
@mattab
Copy link
Member

mattab commented Jun 9, 2015

Looks good to me. Really great to get closer to a green UI test build 👍

@diosmosis diosmosis deleted the fix-ui-tests-again branch June 9, 2015 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab