Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all core plugins to use plugin.json instead of getInformation() #8065

Merged
merged 12 commits into from Jun 9, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 8, 2015

I've converted all usages of getInformation() method to use plugin.json instead.
plugin.json files of all core plugins have also been cleaned and now only contain information that is different from the default value.

in cd1bb24 the translation of the plugin description has been moved. Before it was done when fetching the plugin information. That wasn't good as at that point the correct language wasn't loaded, in addition the plugin information is cached here (before with the incorrect translation)

refs #6061

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jun 8, 2015
mattab pushed a commit that referenced this pull request Jun 9, 2015
Migrate all core plugins to use plugin.json instead of getInformation()
@mattab mattab merged commit 44a7522 into master Jun 9, 2015
@mattab
Copy link
Member

mattab commented Jun 9, 2015

👍

@diosmosis diosmosis deleted the 6061 branch June 9, 2015 21:43
@mattab mattab added answered For when a question was asked and we referred to forum or answered it. and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants