Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup displayed after changing visualization to cities while using the visitor map #8061

Closed
quba opened this issue Jun 8, 2015 · 4 comments
Closed

Popup displayed after changing visualization to cities while using the visitor map #8061

quba opened this issue Jun 8, 2015 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.14.0

Comments

@quba
Copy link
Contributor

quba commented Jun 8, 2015

An error message appears after selecting the cities icon on the bottom left of the Visitor Map. Please see:

screenshot 2015-06-08 09 16 12

While using IE9 there's a popup message displayed. While using Chrome I can see a warning in the browser's console.
@mattab
Copy link
Member

mattab commented Jun 9, 2015

Thanks for the report

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 9, 2015
@mattab mattab added this to the 2.14.0 milestone Jun 9, 2015
@tsteur tsteur mentioned this issue Jun 9, 2015
Merged
@tsteur
Copy link
Member

tsteur commented Jun 9, 2015

I issued a pull request after debugging the issue but I'm not really sure what I'm doing there. It's more like a guess and seems to work but I have no idea whether it causes any side effects.

The alert is triggered within kartograph itself if console is not defined and I'd have to modify kartograph itself to prevent it from triggering alerts.

BTW:
We're currently using 0.5.2 of kartograph.js . We should maybe update to the latest version 0.8.7 as some point to make sure it works in all browsers and to get the performance tweaks that were made etc. I tried to update to latest version but it results in errors and don't know how much work it is to fix it.

@mattab
Copy link
Member

mattab commented Jun 22, 2015

@quba could you confirm issue fixed in latest beta?

@tsteur
Copy link
Member

tsteur commented Jun 23, 2015

Please reopen in case it is not fixed

@tsteur tsteur closed this as completed Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @quba