Fix "disableCookies" does not work in some browers / in some cases #8056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
…that could potentially set a cookie
mattab
pushed a commit
that referenced
this pull request
Jun 8, 2015
Fix "disableCookies" does not work in some browers / in some cases
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7494
I solved three different things here:
disableCookiesis executed before any other method that potentially causes a cookie to be set. To be concrete ifsetSiteIdwas executed beforedisableCookies, it might leave a cookie.deleteCookies()directly whendisableCookies()is called, if possible. Otherwise it is possible that we create a cookie and we would never delete it ifgetRequest()is not executedvalue=''. We setvalue=''when deleting a cookie. This way we make sure to not have potential cookies withvalue=''