By default show all available device types #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
| @@ -26,6 +27,8 @@ protected function init() | |||
|
|
|||
| public function configureView(ViewDataTable $view) | |||
| { | |||
| $unknownTypeCount = 1; | |||
| $view->requestConfig->filter_limit = $unknownTypeCount + count(DeviceParser::getAvailableDeviceTypeNames()); | |||
There was a problem hiding this comment.
fyi @sgiehl: the Device detector DeviceParser is now API as far as Piwik is concerned (maybe it already was, didn't check)
There was a problem hiding this comment.
This was used before in GetType
mattab
pushed a commit
that referenced
this pull request
Jun 8, 2015
By default show all available device types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7920
By default it will show all device types, currently 12. As soon as one changes the limit, the configured limit will be used.