New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injection Inception, Change #7: Store all Singleton's in DI and deprecate base class #8048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
labels
Jun 6, 2015
Moving to 3.0 milestone since this will require changing many plugins. |
…blic (so DI can construct them).
…users do not depend on StaticContainer to get an instance of UIAssetMinifier.
…er::getInstance() and move Twig object into DI.
diosmosis
force-pushed
the
test_env_di_9
branch
3 times, most recently
from
June 30, 2015 22:45
b5b40ed
to
796ed39
Compare
…nGenerator into DI.
…re parameters to Controller::__construct by using StaticContainer, but needs to be solved eventually.
…andlers, instead of StaticContainer.
…d split the DI entry in two, one in a new tracker.php DI config file ('tracker' environment string is already in use).
… to remove entirely, but by deprecating, can hopefully stop increasing its use.
…nce(). Giving up on removing all getInstance)/StaticContainer calls. Must do piecemeal.
… overrides DI container.
…classes that expect Access, it won't fail.
@mattab the changes made are nice and needed eventually but I think we can't complete this PR in near future. I'll close it for now but we can pick the commits later onto Piwik 3 when needed and finish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
This PR is based on #8027.
TODO: