Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection Inception, Change #7: Store all Singleton's in DI and deprecate base class #8048

Closed
wants to merge 26 commits into from

Conversation

diosmosis
Copy link
Member

Work in progress.

This PR is based on #8027.

TODO:

  • For each class that derives from Singleton, remove derivation and replace uses of getInstance() w/ actual DI. (Try at least, may not be possible).
  • At this point, remove uses of StaticContainer where possible.
  • Make sure all plugin tests pass. For those that don't, fix in PR.
  • Look through each commit for things that should go into the CHANGELOG.

@diosmosis diosmosis added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jun 6, 2015
@diosmosis diosmosis self-assigned this Jun 6, 2015
@diosmosis diosmosis added this to the 2.14.0 milestone Jun 6, 2015
@diosmosis diosmosis modified the milestones: 3.0.0, 2.14.0 Jun 6, 2015
@diosmosis
Copy link
Member Author

Moving to 3.0 milestone since this will require changing many plugins.

@diosmosis diosmosis force-pushed the test_env_di_9 branch 3 times, most recently from b5b40ed to 796ed39 Compare June 30, 2015 22:45
@tsteur
Copy link
Member

tsteur commented Aug 30, 2016

@mattab the changes made are nice and needed eventually but I think we can't complete this PR in near future. I'll close it for now but we can pick the commits later onto Piwik 3 when needed and finish it.

@tsteur tsteur closed this Aug 30, 2016
@tsteur tsteur deleted the test_env_di_9 branch August 30, 2016 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants