Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI tests #8041

Closed
wants to merge 11 commits into from
Closed

Fix UI tests #8041

wants to merge 11 commits into from

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Jun 4, 2015

I played with this branch to try and fix the UI tests. In the end it turns out that updating Mocha fixes (at least in the builds I've seen) the segmentation fault. However the build output is all truncated here and there. At first I believed it was due to colors (non-ASCII characters in the output), but disabling it didn't change anything.

Feel free to push commits to this branch, or maybe we should merge it directly: at least we can get the screenshot diffs?

@mnapoli mnapoli added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Jun 4, 2015
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 4, 2015
@diosmosis diosmosis added this to the 2.14.0 milestone Jun 4, 2015
@diosmosis
Copy link
Member

Explicitly allowing colors fixes the console writing issues. I will rebase and merge after a cursory check of the diffs.

@diosmosis
Copy link
Member

Not merging yet, tests are remarkably slow. Need to investigate.

@diosmosis
Copy link
Member

Can't reproduce slow tests locally.

@tsteur
Copy link
Member

tsteur commented Jun 4, 2015

Not merging yet, tests are remarkably slow. Need to investigate.

Is opcache disabled there maybe? I didn't follow whether we disabled it or not.

@diosmosis
Copy link
Member

Is opcache disabled there maybe? I didn't follow whether we disabled it or not.

No. It's disabled for me locally though. Currently building phantomjs w/ debug symbols to profile locally.

@diosmosis diosmosis closed this in d17d6b3 Jun 5, 2015
@diosmosis diosmosis deleted the fix-ui-tests branch June 5, 2015 02:25
@diosmosis
Copy link
Member

Merged in master via squashed merge. The slowness was random, didn't reoccur, though I suppose it will later. Probably due to travis.

@mnapoli
Copy link
Contributor Author

mnapoli commented Jun 5, 2015

Explicitly allowing colors fixes the console writing issues

daaamn and here I was trying to force disable colors ;)

@diosmosis
Copy link
Member

Yeah, don't ask me why :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnapoli @diosmosis @tsteur