Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the contrast of the alerts so that they are more readable #8037

Merged
merged 1 commit into from Jun 3, 2015
Merged

Improve the contrast of the alerts so that they are more readable #8037

merged 1 commit into from Jun 3, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Jun 3, 2015

Fixes #7943

Before

capture d ecran 2015-06-03 a 17 19 27

After

capture d ecran 2015-06-03 a 17 19 15

The "success" alerts are not changed

@mnapoli mnapoli added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Jun 3, 2015
@mnapoli mnapoli added this to the 2.14.0 milestone Jun 3, 2015
@mnapoli
Copy link
Contributor Author

mnapoli commented Jun 3, 2015

Screenshot when used in a form:

capture d ecran 2015-06-03 a 17 23 15

@mnapoli mnapoli mentioned this pull request Jun 3, 2015
Closed
@mnapoli mnapoli added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 3, 2015
@tsteur
Copy link
Member

tsteur commented Jun 3, 2015

it's a bit better now :) Reckon we can make the contrast even higher if needed later.

tsteur added a commit that referenced this pull request Jun 3, 2015
@tsteur
Merge pull request #8037 from piwik/alerts-contrast
c2d7289 
Improve the contrast of the alerts so that they are more readable
@tsteur tsteur merged commit c2d7289 into master Jun 3, 2015
@tsteur tsteur deleted the alerts-contrast branch June 3, 2015 20:55
@mattab
Copy link
Member

mattab commented Jun 5, 2015

yes, love the new high contrast 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnapoli @tsteur @mattab