Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI tests might take a screenshot of a different test / test suite if there's a JS error or so #8033

Closed
tsteur opened this issue Jun 2, 2015 · 3 comments
Closed

UI tests might take a screenshot of a different test / test suite if there's a JS error or so #8033

tsteur opened this issue Jun 2, 2015 · 3 comments
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Milestone
Long term

Comments

@tsteur
Copy link
Member

tsteur commented Jun 2, 2015

It is hard to explain but I'll do my best. In this PR I added a test to ActionsDataTable: https://github.com/piwik/piwik/pull/8018/files#diff-be9457c4f00490761508a5b7d36a8140R95

There under circumstances it was possible that a JS error happens which causes the test to "pause/wait" for like 2 minutes or so. Not quite sure. Meanwhile the next suits BarGraph started which caused for my tests in ActionsDataTable to be taken a screenshot of BarGraph see http://builds-artifacts.piwik.org/ui-tests.master/13001.7/processed-ui-screenshots/ActionsDataTable_auto_expand.png . It took me a long time to figure out what is going on since it worked for me locally and there's not really a way that it could show a bar graph for the PageURLs report etc.

If there's a JS error or so can we maybe report this error immediately and not wait? But maybe take a screenshot immediately though to better be able to analyze it?
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 2, 2015
@diosmosis
Copy link
Member

The new test suite (ie, BarGraph) should do a page load, so it shouldn't be affected by the previous suite. This might be a random phantomjs issue. Sometimes, it takes a screenshot of the last page loaded, instead of the current one. I'm not sure why it happens, and I thought I fixed it by recreating the webpage on each load, instead of reusing them. Some pointer is maybe pointing to the wrong place.

@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Jun 6, 2015
@mattab mattab added this to the Mid term milestone Jul 15, 2015
@mattab
Copy link
Member

mattab commented Jul 15, 2015

If there's a JS error or so can we maybe report this error immediately and not wait?

@tsteur you maybe implemented this feature, since creating this issue?

@tsteur
Copy link
Member Author

tsteur commented Jul 15, 2015

Not really, it can still occur. Can close it though until we see it again somewhere. Reckon will be very hard to fix anyway

@tsteur tsteur closed this as completed Jul 15, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @mattab