Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not setting $resultCheck[false] in core/Filechecks.php function checkDirectoriesWritable. #8032

Merged

Conversation

AndersBillLinden
Copy link
Contributor

It seems like this code could be shortened and corrected. I made some test run to confirm that the error page will be triggered by making the tmp directory non-writable.

mattab pushed a commit that referenced this pull request Jun 3, 2015
…y-in-array

Not setting $resultCheck[false] in core/Filechecks.php function checkDirectoriesWritable.
@mattab mattab merged commit c644d09 into matomo-org:master Jun 3, 2015
@mattab
Copy link
Member

mattab commented Jun 3, 2015

Thanks @AndersBillLinden for the PR

@mattab mattab added this to the 2.14.0 milestone Jun 3, 2015
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 3, 2015
@AndersBillLinden AndersBillLinden deleted the fix-putting-boolean-key-in-array branch June 3, 2015 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants