Correct default language #8022
Closed
Correct default language #8022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // First check forced by request param language setting, | ||
| // then - session language setting, then - from browser, | ||
| // and finally default configured setting. | ||
| $languageCodes = [ |
There was a problem hiding this comment.
Code should be compatible with PHP 5.3
| * @return string Two letters language code, eg. "fr" | ||
| */ | ||
| public static function getLanguageCodeForCurrentUser() | ||
| public static function getCurrentLanguage() |
There was a problem hiding this comment.
This method could be private as the Translator's method should be used instead? (i.e. nobody should use this method)
|
We merged the other PR, thx for this though! We could have not fixed it otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7926.