added action_title_category_reverse to reverse page title after split #8021
Conversation
| @@ -314,6 +315,7 @@ public static function reloadConfig() | |||
| } else { | |||
| self::$actionUrlCategoryDelimiter = self::$actionTitleCategoryDelimiter = $actionDelimiter; | |||
| } | |||
| self::$actionTitleCategoryReverse = Config::getInstance()->General['action_title_category_reverse']; | |||
There was a problem hiding this comment.
One problem that I have is that this setting would apply to all websites therefore would not be usable for many users. @mattab let's maybe discuss this issue later as it could be also interesting for our vision to manage any kind of type #7131, #4734 and especially in #7893 . I see more and more a demand for adding "settings" on a per website basis which is also needed when allowing to create any type in "Sites Management"
There was a problem hiding this comment.
I agree, that this option should be moved to settings. But currently the options for $actionUrlCategoryDelimiter and $actionTitelCategoryDelimiter are also set system wide for all websites. I suggest to apply my patch now, and move all the relating options to website settings later.
|
@mattab what is your opinion on that? |
|
ideally this would be done in a new plugin, that will add a new setting in the "Edit website" screen so one can customise it per-website. IMHO we don't need this feature in core and having it "global" means that it wouldn't be useful for most people... +1 for |
|
Since $actionUrlCategoryDelimiter and $actionTitelCategoryDelimiter are global as well, you can add $actionTitleCategoryReverse as global value and use all this values as default values for the new plugin. So no one is hurt and backwardcompatibility is provided. |
|
Thanks @hannesdorn for the Pull request. We decided not to merge it at this stage. still we hope you will consider contributing again in the future! Cheers |
Hi!
I added a configuration option action_title_category_reverse to reverse the order of the category parts after splitting the title.
page/section/website is splitted into website -> section -> page.
With kind regards
Hannes Dorn