Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite all synchronous XHR as they are deprecated #8020

Closed
tsteur opened this issue May 29, 2015 · 3 comments
Closed

Rewrite all synchronous XHR as they are deprecated #8020

tsteur opened this issue May 29, 2015 · 3 comments
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
4.0.0

Comments

@tsteur
Copy link
Member

tsteur commented May 29, 2015

Since Chrome 43 I am getting this warning in developer tools:

Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.

I noticed especially in Dashboards plugin some sync requests but there might be even more. We need to rewrite those requests to be async.

I'm tagging it as performance/enhancement since it will also make the UI a bit faster. Feel free to change it.
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Performance For when we could improve the performance / speed of Matomo. labels May 29, 2015
@tsteur tsteur mentioned this issue Jun 12, 2015
Merged
@mattab mattab modified the milestones: Short term, 3.0.0 Jun 12, 2015
@barbushin barbushin self-assigned this Jun 24, 2015
This was referenced Jun 24, 2015
Closed
Closed
Closed
@barbushin barbushin mentioned this issue Jul 20, 2015
Closed
@barbushin barbushin removed their assignment Jul 23, 2015
@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0 Aug 13, 2015
@tsteur
Copy link
Member Author

tsteur commented May 18, 2016

FYI: In Piwik 3 UI already all synchronous requests were converted to async mainly because of moving to angular. There are only 6 usages left in the Dashboard plugin and I think 5 of them could be converted by simply converting the xhr.send(true) to xhr.send()

@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b3 Oct 30, 2016
@mattab mattab modified the milestones: 3.0.0-b3, 3.0.0-b4 Nov 14, 2016
@tsteur
Copy link
Member Author

tsteur commented Nov 23, 2016

This could be still delayed a little and done in a 3.1 release

@mattab mattab modified the milestones: 3.0.0-b4, 4.0.0 Dec 1, 2016
@sgiehl
Copy link
Member

sgiehl commented Dec 9, 2019

I guess that one was already fixed with #12546. Did a quick search an couldn't find any remaining synchronous XHR

@sgiehl sgiehl closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
4 participants
@tsteur @mattab @barbushin @sgiehl